1
0
mirror of https://github.com/openbsd/src.git synced 2025-01-10 06:47:55 -08:00
Commit Graph

1340 Commits

Author SHA1 Message Date
naddy
5a0076c3c8 quiz: handle line continuation in data files correctly, switch to getline(3)
Specifically, the following quiz.db line

foo:\
bar

was parsed into "foo:bar\n", which made it impossible to answer correctly.

Bug reported and inital fix from Alex Karle, partially reworked by
yours truly, further input from millert@
2021-03-11 21:18:25 +00:00
jsg
093fc5b92d Add some references, most of these were removed when we stopped building
and installing USD/SMM/PSD docs.

jmc@ agrees with the direction, ok millert@ on an earlier diff
2021-03-08 02:47:25 +00:00
tb
8613de63bb Fix intercardinal directions in hack help.
From Raf Czlonka
2021-03-07 17:08:49 +00:00
mestre
9edb0cbec1 while learning (teachgammon(1)) you might want to save your game so "{w,c}path"
pledge(2) permissions are required
2021-02-06 21:42:30 +00:00
deraadt
d0bb67025f satisfy -fno-common by duplicating deck chairs as required
ok mortimer millert
2021-01-27 01:59:39 +00:00
deraadt
9cf65994f1 satisfy -fno-common
similar to the approach used by mortimer
2021-01-27 01:57:37 +00:00
millert
46c6838e68 Fix build with -fno-common. OK deraadt@ 2021-01-26 20:42:49 +00:00
millert
a6d654780e Ignore special keys returned by the curses getch() function.
Prevents canfield from suspending itself when you resize the window.
Canfield is not prepared to deal with anything other than normal
characters so just ignore them.  OK tb@ pjanzen@
2021-01-21 20:08:17 +00:00
jmc
d075035988 some updates from pjanzen; 2021-01-21 07:12:34 +00:00
schwarze
e8326ca2c6 add the missing EXIT STATUS and HISTORY sections 2021-01-03 01:41:51 +00:00
schwarze
c3f0a71bac Obvious bugfix: requesting a long dictum from a file containing short
ones only or vice versa is an error rather than a recipe for success.
2021-01-03 01:32:13 +00:00
schwarze
6e88d42dcd fix inverted exit status of fortune -m;
bug reported and patch provided
by Tilo Stritzky <lfsdc at gmx dot de> on bugs@;
OK martijn@
2021-01-02 21:35:11 +00:00
zhuk
cb8ad17457 Avoid NULL dereference after returning from copy().
okay martijn@
2020-12-15 14:06:32 +00:00
daniel
166ddc28d1 the names com1 to com9 are reserved filenames on windows
Rename these files in the same way as NetBSD did in 2001. Requested by
John Carmack so OpenBSD source code can be checked out on Windows.

ok deraadt@, sthen@, "go ahead" jsg@
2020-12-15 00:38:18 +00:00
jmc
cbe702d0ae fix unmarked/ignored descriptive mix up;
from rafa
2020-12-13 15:47:32 +00:00
cheloha
fb669f8977 grdc(6): implement timeout with alarm(3)
grdc(6) has an optional argument indicating a timeout in seconds.
For example, one could do:

	$ grdc 60

to to tell grdc(6) to run for sixty seconds and then exit gracefully.

As implemented, however, the timeout may occur too early or too late
if the system clock is reset with settimeofday(2).

To avoid this problem we can instead use alarm(3) and a signal handler
to implement the timeout.  alarm(3) is unaffected by settimeofday(2).
2020-06-06 17:03:16 +00:00
cheloha
6222ba341e grdc(6): miscellaneous style(9)
- Sort includes alphabetically
- Sort function prototypes alphabetically
- Add missing whitespace after commas
- Remove extra whitespace after commas
- Add missing whitespace between binary operators
- Add missing whitespace between reserved words and parens, i.e. fix "if("
- Add missing __dead to usage() definition
2020-06-06 13:21:40 +00:00
schwarze
d167610cf6 no need to declare "extern optarg" and "extern optind"
when <unistd.h> is included;
patch from Jan Stary <hans at stare dot cz>;
OK millert
2020-02-14 19:17:33 +00:00
espie
3367dcf595 a few depend:-related thingies that were still in.
okay millert@, tb@
2019-12-21 21:39:59 +00:00
jmc
81b7b661bd fix gary zukav's "acceptance without proof" quote, which just appeared on
my screen.

i don;t have a copy of this book, and a brief search online shows conflicting
punctuation, but i've chosen to replace the comma splice with a full stop,
which is at least grammatically correct, and seems the most likely solution.

whether this quote needs to be in two files escapes me...
2019-09-27 20:44:22 +00:00
schwarze
32a8c8b51d Be more specific regarding which encoding this simulator generates:
the existing text encouraged the misconception that punched card
encodings were somehow standardized, which they were not.  Lots of
different encodings existed, and the one simulated here was a
proprietary one of one specific vendor (GE).  Also correct the
history: the folks at Bell Labs already played with this.

HISTORY mistake noticed by Sevan Janiyan <venture37 at geeklan
dot co dot uk>, who also agrees with the final patch.

tweak and OK jmc@
2019-09-08 22:43:46 +00:00
deraadt
4d9461faa6 Move 4 manual pages from not-a-function filenames to a correct filename,
and correct Xr.
ok jmc
2019-08-30 18:33:17 +00:00
jmc
4279707e7c spelling fix and zap a stray line while here; 2019-08-22 16:32:26 +00:00
deraadt
df69c215c7 When system calls indicate an error they return -1, not some arbitrary
value < 0.  errno is only updated in this case.  Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.
2019-06-28 13:32:41 +00:00
lteo
41daf97413 Remove unused variables; no binary change.
From Jake Champlin
2019-05-20 02:11:22 +00:00
rob
41b007386b Unveil tetris.
ok brynet@, tedu@
2019-05-18 19:38:25 +00:00
schwarze
ab9f6680fc patch from <tleguern at bouledef dot eu> to support backward rotation,
hoping to save somebody's life from the Leather Goddesses of Phobos
2019-05-15 15:59:24 +00:00
jmc
724fe9d8c7 eaktway eviouspray; 2019-05-12 06:07:36 +00:00
tedu
189fbbeead add an example to the man page. discovered by mlarkin 2019-05-11 23:52:17 +00:00
tedu
84f04a3e43 rm lists of hereditary wizards and bad users to ensure level playing field
ok benno mlarkin tb
2019-05-09 20:19:22 +00:00
jmc
75bcd186ff macro args and punctuation should be space spearated;
from fabio scotoni
2019-04-08 17:49:07 +00:00
bentley
dc14b708bc Fix hack(6).
- Write savegames and scorefiles to the current directory instead of /var
- Save oc_name and oc_descr alongside oc_uname in all situations
- When a levitation potion times out, explicitly float down

These patches were contributed last year by "tonypony76"; thanks!

ok deraadt@, with added enthusiasm from tedu@
2019-04-05 09:02:27 +00:00
tb
d2ba0c38d7 g/c unused robots_roll file.
From Randy Hartman
2019-02-26 07:14:35 +00:00
schwarze
b28c290522 missing word found in my tree 2019-02-06 15:02:01 +00:00
schwarze
a44abf720c give the fake latin proverb "per aspera ad astra" in the more
commonly used and metrically and logically more pleasant word
order, and fix the wrong translation;
translation error reported by Alessandro de Laurenzis on tech@;
OK pascal@ jmc@
2019-02-03 13:35:33 +00:00
tedu
3bce2bd62b printing the pinball bonus in the corner is confusing when you lose.
just let the bonus happen if it does, players will figure it out.
2019-01-20 04:14:19 +00:00
tedu
59bfb9d6a7 remove some obsolete comments about deleted code 2019-01-20 04:12:58 +00:00
tedu
ae3bacb543 quick fix to keep the cursor in the corner during space warp.
less distracting this way.
2019-01-20 04:10:12 +00:00
tedu
e87918d773 if the snake ran over the money, print the treasure instead of empty.
bug noticed by mlarkin
2019-01-20 04:09:15 +00:00
tedu
8ca82b0009 allow q to exit the program.
ok cheloha deraadt schwarze
2019-01-06 18:27:14 +00:00
tedu
2e2e33a122 convert to unsigned variables to avoid some overflows.
analysis and patch from David Fifield
2018-12-27 17:27:23 +00:00
schwarze
6106ce73d6 Move a badly positioned parenthesis that caused nonsensical movement
properties for the Wumpus.  The bug has been present since 4.3BSD-Reno
and was introduced by Keith Bostic on February 14, 1990 when committing
the major rewrite from Dave Taylor.

Patch (accompanied by a detailed functional and historical analysis)
from David Fifield <david at bamsoftware dot com> on bugs@.

With all the bats in these caves, how could a bug possibly survive
for twenty-eight years?
2018-12-20 09:55:44 +00:00
tb
b5c67e29cb More fixes from David Fifield:
First, fill a missing pixel in the glyph for 'U'.

Second, fix an off-by-one in the line output routine. This caused an
extra space character to be output at the end of every line. It might
have caused a buffer overflow if any glyph had used the entire possible
width of 132 pixels, but as it is the widest is only 124 pixels.

Third, output blank lines instead of lines full of spaces (the number of
spaces was equal to the width of the most recent non-blank line).

Finally, add bounds checks to protect against buffer overflows that could arise
in case the data table were ever modified to draw out of bounds (characters
wider or taller than 132 pixels, or a two-byte code where the second byte is
past the end of the table).

ok bcallah
2018-10-16 20:06:42 +00:00
tb
76b6612d58 Remove unused data table entries: 174 out of 9271 entries of the bitmap
data table are unused and can be eliminated by rendering al glyphs and
re-encoding them. A few more entries can be eliminated through more
efficient encoding.

Patch generated with a python program by David Fifield.
For details see https://marc.info/?l=openbsd-bugs&m=153955110702704&w=2

ok bcallah
2018-10-16 19:56:55 +00:00
bentley
378bc3c488 Fix fortune underlines and use the right number of underscores in Notes.
ok sthen@
2018-09-15 09:44:19 +00:00
mestre
e4a577c2d1 During our refactor with tedu@ tb@ and myself we moved the score file to the
user's home folder and setgid was removed. Therefore it's not possible to have a
single score file with all the users anymore but we forgot to change a comment
that still implied that.

Suggested by tb@ to just delete the comment.
2018-08-24 11:31:17 +00:00
mestre
b9f1292116 Remove a few too early pledge(2)s on games/ and apply them a little bit later
but with much reduced permissions ("stdio tty" if ncurses based and "stdio"
for the ones that only perform basic operations).

There's still a few games that we cannot yet remove their fs access, through
pledge(2), since they open files on demand and too late, this might get
revisited in the future.

OK tb@
2018-08-24 11:14:49 +00:00
mestre
8ac81e2dac reduce pledge(2) to "stdio tty" after ncurses initialization. robots(6) uses a
scorefile nevertheless an fd is opened way in advance and therefore we can
disable any further access to the filesystem.

OK tb@
2018-08-23 06:26:35 +00:00
mestre
c5ef424a48 reduce pledge(2) to "stdio tty" after ncurses initialization.
OK tb@
2018-08-23 06:25:01 +00:00
mestre
e6afc4b502 The game is playable without the need to access any files therefore we can
effectively disable all fs access by dropping "rpath wpath cpath" from
pledge(2) right at the beginning of the program.

"looks right" tb@
2018-08-09 17:51:22 +00:00