naddy
143054fa78
Switch cdio's default CDDB database to gnudb.gnudb.org:8880.
...
The freedb.org CD track database has been discontinued.
Retire cddb/888 from /etc/services. Nothing uses this any longer.
gnudb.org uses the "cddbp-alt" port of 8880, but we don't need a
services(5) entry for a single site.
ok deraadt@
2020-06-26 19:51:14 +00:00
krw
1c866f68ca
Let it compile again.
2017-12-07 02:08:44 +00:00
espie
b356b55ad8
be consistent in where we call fflush
...
okay millert@
2017-12-06 17:15:43 +00:00
deraadt
b9fc9a728f
Replace <sys/param.h> with <limits.h> and other less dirty headers where
...
possible. Annotate <sys/param.h> lines with their current reasons. Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution. These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)
2015-01-16 06:39:28 +00:00
espie
98f738e746
fgetln may return incomplete lines (Tobias Stoeckmann <tobias@stoeckmann.org>)
...
simple solution: error out. This is not a correct cddb answer anyways.
2014-01-06 12:38:10 +00:00
tobias
61dbd8aa4e
Properly validate index value received from CDDB server.
...
ok deraadt@, millert@
2014-01-04 15:39:17 +00:00
espie
c14b1d516c
fix atrocious code, do socket -> FILE* conversion correctly, with proper
...
error handling.
okay millert@, otto@
2013-03-07 16:54:28 +00:00
miod
691235adb9
Avoid using NULL in non-pointer contexts: use 0 for integer values and '\0'
...
for chars.
2011-04-06 11:36:23 +00:00
fgsch
579d55c92f
o if no argument is passed to cddbinfo, treat it as 0 in order to print
...
the list in case of multiple/inexact matches
o if the argument to cddb is invalid, do not exit, just print and error
and ignore the command
espie@ ok.
2008-04-27 23:06:40 +00:00
cloder
fd338a6277
Make sure we don't skip the code which sends the QUIT command to the CDDB
...
server and validates the returned track names. Unreachable code spotted
by lint.
OK krw@, deraadt@, espie@
2007-09-10 16:31:35 +00:00
deraadt
1ed98fdf61
use calloc() to avoid malloc(n * m) overflows; checked by djm canacar jsg
2007-09-02 15:19:07 +00:00
jdixon
f925fb2547
use strtonum; ok millert@
2007-05-01 01:26:12 +00:00
millert
d07eb5f84f
Include <sys/param.h> instead of <sys/types.h> so we get MAXHOSTNAMELEN
2006-01-23 17:29:22 +00:00
aaron
94f074361a
Fix malloc calculation to avoid memory bounds error. deraadt@ ok
2006-01-17 00:56:04 +00:00
deraadt
f760b59d08
more asprintf; ok dhill@mindcry.org
2005-11-12 15:26:23 +00:00
espie
ce2747ceab
Protect all get_line calls against null pointers.
...
Problem pointed out by Pedro Bastos, thanks Pedro.
2003-06-09 11:33:14 +00:00
espie
45694746ac
my style: length is size_t, not int.
2003-03-13 09:32:06 +00:00
deraadt
334e018b42
lots of sprintf -> snprintf and strcpy -> strlcpy; checked by tedu
2003-03-13 09:09:20 +00:00
espie
7c9f4bc9f6
handle multiline replies from the server.
...
this actually happens on the 3.2 audio CD.
ok millert@
2002-12-14 21:28:08 +00:00
espie
ae359c1c7d
Reuse cddb code to support FreeBSD new cdid command.
...
(who knows ? scripts might use it).
ok fgs@, pval@
2002-04-18 22:17:04 +00:00
espie
288d24dce4
remove extra spaces, fix rcsid (noticed by millert)
2002-04-18 22:07:04 +00:00
deraadt
8459c98c05
KNF
2002-04-18 21:48:36 +00:00
espie
9ed7639af4
Add cddb support.
2002-04-18 20:18:31 +00:00
