mischief/openbsd-src
1
0
Fork 0
mirror of https://github.com/openbsd/src.git synced 2024-12-22 16:42:56 -08:00
Code
227,813 Commits 1 Branch 0 Tags 805 MiB
4dacb8188c
Commit Graph

227813 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
kettenis
0738886a59 Add some extra parenthesis for consistency. 
stolen from jsing@
 2023-07-04 09:00:24 +00:00
tb
df6ddd9b8f Plug leak in the ssltest 
Removing -tls1 moved some tests from the legacy stack to the TLSv1.3 stack.
On a HRR, the alpn callback would be called twice and allocate the global
twice, thereby leaking. So free it up front.

Joint suffering with bcook and beck
 2023-07-04 08:47:01 +00:00
tb
3cbf61e9eb Factor the computation of ECDSA s into a function 
ossl_ecdsa_sign_sig() is already complicated enough. The math bit is
entirely self contained and does not need to obfuscate control flow
and logic.

with feedback from and ok jsing
 2023-07-04 07:38:31 +00:00
espie
e791f78712 document the recent addition of "Building from scratch" and what it means. 2023-07-04 07:04:11 +00:00
dlg
fe20b749ab add support for unix domain sockets to ssh -W 
ok djm@ dtucker@
 2023-07-04 03:59:21 +00:00
jsg
49ad723553 m_reclaim() was removed in uipc_mbuf.c rev 1.195 2023-07-04 03:56:07 +00:00
dlg
5877e94067 a little knf, no functional change 2023-07-04 02:56:11 +00:00
jsg
c40d78fe1e remove unused global var 
ok sashan@
 2023-07-04 02:01:55 +00:00
espie
4567bf82f2 record when pkg_add is actually doing something. 
details of rc code to be set in stone later (currently as an option)
 2023-07-03 19:12:08 +00:00
anton
d3804626eb favor REGRESS_EXPECTED_FAILURES 2023-07-03 17:55:51 +00:00
espie
de2fb8e9b2 also make things 5.36 if not used 2023-07-03 17:01:59 +00:00
nicm
cbbd91a4a8 Add support for marking lines with a shell prompt based on the OSC 133 
extension, from Munif Tanjim in GitHub issue 3596.
 2023-07-03 16:47:43 +00:00
tobhe
40c18b20f5 Enable mouse.tp.mtbuttons for apldcms 
ok bru@
 2023-07-03 15:54:07 +00:00
kn
63832deb67 use consistent queue(9) example for LIST removal; OK bluhm mvs 2023-07-03 15:52:51 +00:00
krw
498920cd2d An empty string indicates there is no NXTNUM(). 
Fixes segfault in -e if you happen to delete everything after
a partition line's ":".
 2023-07-03 15:27:07 +00:00
tb
6873ed407b sign_sig: drop ckinv 
The only reason ckinv exists is to be able to avoid a copy. This copy
leaks some timing info, that will be mitigated in a subsequent step.
It is an unused or at least uncommonly used codepath.

ok jsing
 2023-07-03 14:51:09 +00:00
tb
0df1a5ef3f Rework the logic in ECDSA sign_sig() 
If the caller supplied both kinv and r, we don't loop but rather throw
an undocumented error code that no one uses, which is intended to tell
the caller to run ECDSA_sign_setup() and try again.

Use a boolean that indicates this situation so that the logic becomes
a bit more transparent.

ok jsing
 2023-07-03 13:53:54 +00:00
jasper
03c8fe6abc add regress tests for the remainder of the function provided by our uuid.h 2023-07-03 13:51:55 +00:00
jasper
c367081c09 add a few tests related to --cflags and --libs in combination with Requires.private. 
skipping one (currently failing) test which exhibits the behaviour described
by humm@ljabl.com on bugs@
 2023-07-03 13:44:45 +00:00
claudio
8bc5e3a3aa Use new ibuf API. Use ibuf_data() and ibuf_size() instead of direct 
struct access and use ibuf_set_n16() to update the length field.
OK tb@
 2023-07-03 11:51:27 +00:00
tobhe
d16bc87a13 Delete some more references to dead policy code. 
Fixes -DNAMESPACE

ok tb@
 2023-07-03 11:43:15 +00:00
tb
026eb4403c sign_sig: test on assignment 2023-07-03 11:10:28 +00:00
tb
492aa073e7 sign_setup: split another check into two 2023-07-03 11:06:28 +00:00
tobhe
303eb4507d typo 2023-07-03 10:59:16 +00:00
nicm
2cba1c74a7 Do not risk writing over the end of the buffer when it ends in # 
(because strchr \0 will be non-NULL), reported by Robert Morris in
GitHub issue 3610.
 2023-07-03 10:48:26 +00:00
claudio
7551d11f80 Use ibuf_data() and ibuf_size() instead of accessing struct ibuf. 
OK tb@
 2023-07-03 10:34:31 +00:00
claudio
aa2e6c71fe Use ibuf_data() and ibuf_size() instead of accessing struct ibuf. 
OK tb@
 2023-07-03 10:34:08 +00:00
tb
6f1869804a Split range checks for ECDSA r and ECDSA s 
requested by jsing
 2023-07-03 10:21:25 +00:00
tb
a40eee643d Switch a couple of test from ucmp to cmp 
This is confusing, as both sides involved should be unsigned. The ec
code is undecided on whether the group order can be negative. It should
never be, so lets see what happen with this slightly stricter check.

discussed with jsing
 2023-07-03 10:19:52 +00:00
tb
4cb16a19a0 ossl_ecdsa_verify_sig(): simplify range checks 
The checks whether r and s lie in the interval [1, order) were a bit
uglier than necessary. Clean this up.

ok beck jsing
 2023-07-03 10:16:14 +00:00
tb
7923245515 List variables in a somewhat more sensible order 2023-07-03 10:10:58 +00:00
tb
08418048a9 In ossl_ecdsa_verify_sig() use BN_CTX more idiomatically 
ok beck jsing
 2023-07-03 10:09:12 +00:00
tb
f316530d59 Split a bunch of unrelated checks 
ok beck jsing
 2023-07-03 10:06:00 +00:00
tb
b6b844f8a9 Make ossl_ecdsa_verify_sig() single exit 
ok beck jsing
 2023-07-03 10:04:05 +00:00
tb
5b8a1898b2 Switch ossl_ecdsa_verify() to timingsafe_memcmp() 
Requested by jsing
 2023-07-03 09:59:20 +00:00
tb
a4525479f3 Streamline ossl_ecdsa_verify() 
Make it single exit and use API more idiomatically and some other
cosmetics.

ok beck jsing
 2023-07-03 09:55:42 +00:00
claudio
bf2cf3053d Use ibuf_data() instead of direct access to ibuf->buf, 
use ibuf_size() instead of direct access to ibuf->wpos,
use ibuf_left() in places where the code checks if there is enough
space left in the ibuf.
OK tb@
 2023-07-03 09:51:38 +00:00
claudio
a50d52cbc8 Use ibuf_data() instead of directly accessing ibuf->buf. 
OK tb@
 2023-07-03 09:40:47 +00:00
claudio
bce5c5dd58 Use ibuf_data() instead of accessing ibuf->buf directly. 
OK tb@
 2023-07-03 09:38:08 +00:00
tb
a01b15c12b Explicit parameter printing can also use get0_order() 
ok beck jsing
 2023-07-03 09:37:30 +00:00
tb
b8a9031a05 Convert ossl_ec_key_gen() and EC_KEY_check_key() 
These also get the EC_GROUP_get0_order() treatment

ok beck jsing
 2023-07-03 09:35:26 +00:00
tb
71ee631559 Convert EC_GROUP_check() to EC_GROUP_get0_order() 
ok beck jsing
 2023-07-03 09:29:55 +00:00
tb
5eecd1d368 Inline two copies of EC_GROUP_order_bits() 
This code is way more complicated than it needs to be. Simplify. ec_bits()
was particularly stupid.

ok beck jsing
 2023-07-03 09:25:44 +00:00
jsg
3a7451b441 use semicolon not comma at eol 
ok stsp@
 2023-07-03 09:12:05 +00:00
jasper
a46eaf1e2c fix uuid_dec_{b,l}e prototypes 
ok jmc@
 2023-07-03 08:53:27 +00:00
jmc
fb7701837e some minor fix up; 2023-07-03 08:37:22 +00:00
nicm
423d19d0e7 Another warning fix for GCC from Thomas Klausner. 2023-07-03 08:37:14 +00:00
jasper
d4fb4f4dde when shutting down a vm, handle the VM id in the same way as a VM name argument 
ok dv@
 2023-07-03 08:32:20 +00:00
krw
ff4895b7e4 Nuke unused label 'next:'. 2023-07-03 08:16:36 +00:00
beck
b5c24d4f5d Bring back no_tls1 and no_tls1_1 as undocumented silently discarded opitons 
While I'm here, change the no_ssl2 and no_ssl3 options to use
OPTION_DISCARD as well instead of continuing to set a no-op
option flag.

ok jsing@ tb@
 2023-07-03 08:03:56 +00:00