1
0
mirror of https://github.com/openbsd/src.git synced 2024-12-21 23:18:00 -08:00
Commit Graph

237195 Commits

Author SHA1 Message Date
tb
59c41a1786 Fix previous and thus regress failures reported by anton
Looks like I applied the diff to a dirty tree and didn't notice.
2024-12-06 07:10:20 +00:00
dtucker
f6b912702f Expand $SSH to absolute path if it's not already. Prevents problem
later in increase_datafile_size if ssh is not in the path.  Patch from
quaresmajose via GHPR#510.
2024-12-06 07:05:54 +00:00
dtucker
c05259c408 Change "login again" to "log in again" in password change message. From
ThinLinc-Zeijlon via github PR#532.
2024-12-06 06:55:28 +00:00
tb
ce5fd5cb4f ec_asn1: update a comment to match reality 2024-12-06 05:13:35 +00:00
tb
c9c3f1d69f Set nid on group decoded from EC parameters
We match curve parameters against the builtin curves and only accept
them if they're encoding a curve known to us. After getting rid of the
wtls curves, some of which used to coincide with secp curves (sometimes
the wrong ones), the nid is unambiguous. Setting the nid has no direct
implications on the encoding.

This helps ssh avoid doing ugly computations during the key exchange
for PEM keys using this encoding.

ok djm joshua jsing
2024-12-06 04:35:03 +00:00
naddy
b56918e34f catch up documentation: AES-GCM is preferred to AES-CTR 2024-12-05 22:45:03 +00:00
kettenis
47e192534f Query hardware for the button state such that we can detect the release
even if we miss the press event.  Change the driver such that wakeup is
signalled when the button is pressed such that it matches what happens
when wakeup is handled by the PMIC.

ok patrick@
2024-12-05 21:35:39 +00:00
tb
f88101f637 Zap a trailing space 2024-12-05 19:57:37 +00:00
tb
fa7ea96644 Make the DSS_prime_checks macro internal
Rename it to DSA_prime_checks and add an XXX comment mentioning that
we could reduce the number of rounds thanks to BPSW. There are no
plans of changing that as DSA is on its way out.

discussed with miod
2024-12-05 19:34:46 +00:00
tb
66be9a589c Remove the undocumented DSA_is_prime() macro
It aliases BN_is_prime(), which was removed in April 2023.

makes sense to miod
2024-12-05 19:29:08 +00:00
schwarze
95240d2fe0 document the #define'd constant PKCS5_SALT_LEN 2024-12-05 15:12:37 +00:00
schwarze
50ad0749e0 drop comments asking for documentation of three ASN1_PKEY_CTRL_CMS_*
constants after these have been marked as intentionally undocumented;
they are internal to the library and unused in the wild
2024-12-05 15:06:27 +00:00
claudio
3edd791eb4 cursig() can return a normally ignored signal if the process is ptraced.
So make sure that sleep_signal_check() returns ERESTART in that case so
that the syscall is retried once ptrace intercepted the signal.

This should fix unexpected EINTR returns of waitpid for precesses that
left SIGCHLD ignored (default). Not the perfect fix but a good enough
bandaid to allow people to debug processes doing forks and waitpid calls.

Problem reported and fix tested by stsp@
OK kettenis@ stsp@
2024-12-05 14:53:55 +00:00
dtucker
c9baf54040 Add key expiry test in the 64bit time_t range for additional coverage.
From Alexander Kanavin via bz#3684.
2024-12-05 14:28:39 +00:00
schwarze
10e3f8f482 Mark three EVP_PKEY control constants for CMS as intentionally undocumented
that are internal to the library and unused in the wild
2024-12-05 14:01:59 +00:00
schwarze
226533405b mark three more EVP_PKEY control constants as intentionally undocumented
that are only intended for internal use and unused in the wild
2024-12-05 10:58:12 +00:00
schwarze
ca8f98200d ignore DECLARE_PKCS12_STACK_OF such that pkcs12.h can be parsed 2024-12-05 10:52:45 +00:00
stsp
fa26180998 add missing vlan.h header to ice(4) and fix build; spotted by jsg@
tested with vlan(4) on top of ice(4) between openbsd and freebsd
ok jsg@
2024-12-05 09:55:50 +00:00
tb
54c494921a Apply a little bit of lipstick to PKCS7
Makes the setting and getting of detached signatures more symmetric
and avoids a NULL access.

ok jsing
2024-12-05 07:35:46 +00:00
dtucker
14d1766073 De-magic the x11 base port number into a define. ok djm@ 2024-12-05 06:49:26 +00:00
dtucker
0a9ac28277 Prevent integer overflow in x11 port handling. These are theoretically
possible if the admin misconfigures X11DisplayOffset or the user
misconfigures their own $DISPLAY, but don't happen in normal operation.
From Suhov Roman via bz#3730, ok djm@
2024-12-05 06:47:00 +00:00
mvs
dac6e0759a Push locking down to udp_sysctl().
No locks required for per-CPU counters based protocol statistics.
Atomically accessed `udpctl_vars' variables are already moved from the
net lock, sysctl(2) related locks are useless for them.

Complicated UDPCTL_BADDYNAMIC and UDPCTL_ROOTONLY cases were left as is.

ok bluhm
2024-12-04 22:48:41 +00:00
mvs
854a7367f7 Push locking down to icmp_sysctl().
Keep locking only for ICMPCTL_REDIRTIMEOUT case. It is complicated, so
left it as is.

ICMPCTL_STATS loads per-CPU counters into local data, so no locking
required.

`icmpctl_vars' are atomically accessed integers. Except `icmperrppslim'
they are simply booleans, so nothing special required. Used the local
`icmperrppslim_local' variable to load `icmperrppslim' value because it
it could have negative values. claudio@ proposed to always load such
values to local variables, so I want to try this notation.

ok bluhm
2024-12-04 22:24:11 +00:00
tb
aaa88f3d70 Use ASIdentifiers rather than struct ASIdentifiers_st
This matches the other members of X509 and is what's used everywhere else.

ok miod
2024-12-04 20:07:16 +00:00
nicm
6338d89d41 Fix backspace option for new key format, GitHub issue 4284. 2024-12-04 19:11:15 +00:00
mvs
b9b60940b5 Unlock gre_sysctl().
Both `gre_allow' and `gre_wccp' are atomically accessed integers. They
could have only '0' and '1' values, so no extra dances around
atomic_load_int(9) required.

ok bluhm
2024-12-04 18:20:46 +00:00
djm
a8b9d72961 add a work-in-progress tool to verify FIDO attestation blobs
that ssh-keygen can write when enrolling FIDO keys.
2024-12-04 16:42:49 +00:00
job
b5d1cb3f60 Update references for recent RPKI specifications 2024-12-04 16:17:31 +00:00
djm
8823bb00fc sync the list of options accepted by -o with ssh_config.5
prompted by bz3455
2024-12-04 14:37:55 +00:00
djm
e2c061ecb9 don't screw up ssh-keygen -l output when the file contains CR
characters; GHPR236 bz3385, fix from Dmitry Belyavskiy
2024-12-04 14:24:20 +00:00
sthen
52e728d076 use kmem(4) instead of "all memory" which has more information about
what exactly is allowed, and specifically refers to allowkmem (and that
it permits both /dev/mem and /dev/kmem). discussed with deraadt
2024-12-04 13:16:26 +00:00
jsing
550a1cbd21 Another now unused perlasm script can bite the dust. 2024-12-04 13:14:45 +00:00
jsing
a61493a0f2 Provide a replacement assembly implementation for SHA-1 on amd64.
As already done for SHA-256 and SHA-512, replace the perlasm generated
SHA-1 assembly implementation with one that is actually readable. Call the
assembly implementation from a C wrapper that can, in the future, dispatch
to alternate implementations. On a modern CPU the performance is around
5% faster than the base implementation generated by sha1-x86_64.pl, however
it is around 15% slower than the excessively complex SSSE2/AVX version that
is also generated by the same script (a SHA-NI version will greatly
outperform this and is much cleaner/simpler).

ok tb@
2024-12-04 13:13:33 +00:00
dtucker
960594bd76 Don't assume existence of SK provider in test.
Patch from balu.gajjala at gmail via bz#3402.
2024-12-04 10:51:13 +00:00
sthen
9b8b48b50a Mention kern.allowdt and kern.allowkmem in examples/sysctl.conf.
From espie, ok claudio mpi
2024-12-04 10:14:14 +00:00
tb
04521d92d0 Annotate WTLS7 as being wrong
This should really have been using SECP 160R2, not SECP 160R1. Of course
this means in particular that nobody ever used this curve, at least not
against another implementation than OpenSSL. Quasi-monocultures are
poisonous whether the monopolist is benevolent and competent or not.
2024-12-04 09:50:52 +00:00
mpi
8ce4994e23 Disallow enabling the same probe multiple times.
From Christian Ludwig.
2024-12-04 09:37:33 +00:00
mpi
2896583250 Regression for multiple probes. 2024-12-04 09:35:21 +00:00
mpi
ffce2a5431 Disallows registering multiple probes of the same type.
If a bt(5) script uses the same probe multiple times (like interval:hz),
btrace(8) has currently no knowledge of which rule to execute when it
parses events read from the kernel.

Disable the funcitonnality until someone in need of such feature comes
up with a nice implementation.

From Christian Ludwig.
2024-12-04 09:33:41 +00:00
mpi
07c549d831 Document that the original page during a CoW can be unlocked earlier.
ok tb@
2024-12-04 09:21:06 +00:00
mpi
335383c917 Pass the rw_enter(9) type to amap_lock() in preparation for using shared locks.
ok tb@
2024-12-04 09:19:11 +00:00
tb
e8e63f6878 Fix up authority and subject key identifiers in force pubkey mode
Upstream decided that this nonsense was worth an ABI break and added stuff
to the X509_CTX so they could hang the issuer's public key off it so that
they could adjust the key identifiers as needed. Let's avoid that and do
it the slightly less nasty way by updating the AKI and SKI as needed.

We only do this when force pubkey is in place so we don't change the
semantics of the batshit crazy config language that nobody understands.

ok job
2024-12-04 08:14:34 +00:00
tb
ddff58c964 Fix debug output for http headers
from Kenjiro Nakayama
2024-12-04 07:58:51 +00:00
kmos
ca433cef96 Bump datasize-cur for the pbuild user on sparc64 so that we can
build llvm 18.

ok sthen
2024-12-04 06:01:23 +00:00
jsg
3bb7d5b07c spelling; ok djm@ 2024-12-03 22:30:03 +00:00
sf
ff0ccef3c1 vio: Unlock, switch to qstart function
Run without kernel lock. Use the network stack functions used for
multiqueue, but still only run on one queue.

Add a virtio interface for an interrupt barrier.

This is the reverted diff plus a missing chunk.
Tested by dtucker, bluhm, sf
2024-12-03 19:14:40 +00:00
dtucker
8aa1e807a7 Remove fallback to compiled-in gropup for dhgex when the moduli file
exists, but does not contain moduli within the client-requested range.
The fallback behaviour remains for the case where the moduli file does
not exist (typically, running tests prior to installing).
From bz#2793, based in part on patch from Joe Testa, ok djm@
2024-12-03 16:27:53 +00:00
tb
773a72803d Remove redundant field of definition check
This will allow us to get rid of EC_GROUP_method_of() in the near future.

ok djm
2024-12-03 15:53:51 +00:00
job
dab7a176b1 Add more checks for router keys
OK tb@
2024-12-03 14:51:09 +00:00
claudio
7aa5115960 Remove the FUSE hack in ufs_ihashget() it is no longer needed.
FUSE switched away from the horrible ufs inode abuse and so this is
no longer reached.
OK millert@ tb@ miod@
2024-12-03 14:41:45 +00:00