1
0
mirror of https://github.com/openbsd/src.git synced 2025-01-03 06:45:37 -08:00
Commit Graph

295 Commits

Author SHA1 Message Date
yasuoka
6805751f43 Transition to "Req-Sent" had been missing when RTA in "Opened". This caused
a timer event leak.  Diff from Yuuichi Someya.
2016-03-16 04:55:41 +00:00
yasuoka
5e4e58f11f Fix: "authconf.users_file_path" is a char[] but is checked as a char*.
Diff from Mathieu Papineau (via Claer)
2016-03-08 02:05:00 +00:00
yasuoka
ff9f38b576 Remove __cplusplus include guard.
Diff from Tiago Silva
2016-03-08 01:38:04 +00:00
sthen
e962b3caab Remove setproctitle() for the parent process. Because rc.d(8) uses process
titles (including flags) to distinguish between daemons, this makes it
possible to manage multiple copies of a daemon using the normal infrastructure
by symlinking rc.d scripts to a new name. ok jung@ ajacoutot@, smtpd ok gilles@
2016-02-02 17:51:11 +00:00
mmcc
3096681be7 s/failes/failed/g 2015-12-17 18:37:58 +00:00
tb
1475b7aad9 Replace 'arc4random() % (2^k - 1)' by 'arc4random() & (2^k - 1)' to
avoid modulo bias.  Part of a diff by Matthew Martin, reviewed by
deraadt@ and me.

ok deraadt@
2015-12-17 08:09:20 +00:00
tb
ae505340fa Add missing $OpenBSD$ tags. 2015-12-17 08:01:55 +00:00
tb
2632528fdd Replace arc4random() % i by arc4random_uniform(i) to avoid modulo bias.
Part of a diff by Matthew Martin, reviewed by deraadt@ and me.

ok deraadt@
2015-12-17 07:56:01 +00:00
mmcc
900232727d strings.h -> string.h to prevent an implicit declaration. Also remove a
bunch of NULL-checks before free().
2015-12-05 18:43:36 +00:00
yasuoka
41d69f6e70 Pass the pppx_hdr when sending packets through the pppx device and use the
ppp_id in the pppx_hdr to find the associated ppp when receiving the packets
from the device.
2015-12-05 16:10:31 +00:00
claudio
1f82c02d17 EAGAIN handling for imsg_read. OK henning@ benno@ 2015-12-05 13:19:32 +00:00
yasuoka
268187f4a7 Fix typo in #include line. 2015-12-04 13:12:44 +00:00
yasuoka
00f24e10a7 Remove files which had been unused. 2015-12-04 12:15:57 +00:00
mmcc
822b50ff39 comment typo 2015-12-02 05:07:09 +00:00
yasuoka
0cd27c4a1b Remove -h from the command line options.
diff from Benjamin Baier
2015-11-09 01:14:22 +00:00
guenther
116a5cae52 Simplify and lock down priv_open():
* kill the 'mode' argument
 * fail if passed any flags other than O_ACCMODE OR O_NONBLOCK
 * paranoia: mask O_CREAT when calling open() with only two arguments
 * instead of using ioctl(FIONBIO) after the fact, pass O_NONBLOCK to
   priv_open()

"good start" deraadt@
ok yasuoka@
2015-10-11 07:32:06 +00:00
guenther
847420c88c YYSTYPE.number is int64_t, so format with <inttypes.h>'s PRId64
ok yasuoka@
2015-10-11 07:16:01 +00:00
sobrado
0600642d68 typo in documentation. 2015-09-21 10:40:16 +00:00
mpi
3ec8e064e9 Set the index of the interface in handroller link_addr(3) like code.
This is now necessary on OpenBSD because our routing interface no longer
use ifunit() to find the corresponding interface.

ok yasuoka@, dlg@
2015-09-13 08:22:10 +00:00
deraadt
74590bb3de stdlib.h is in scope; do not cast malloc/calloc/realloc* 2015-08-20 22:46:32 +00:00
yasuoka
579578a4c1 Make npppd use libradius(3). Remove radius+ files. 2015-07-23 09:04:06 +00:00
yasuoka
7e8328a552 Add size and NULL checks in debugutil.c
Poined out by Yuuichi Someya at IIJ.
2015-07-20 19:26:41 +00:00
yasuoka
213076fa62 Pass the errcode when disconnecting L2TP call.
From Yuuichi Someya at IIJ.
2015-07-20 19:03:54 +00:00
yasuoka
c163cc1289 Remove old route to the tunnel interface when the interface's address is
changed.

From Yuuichi Someya at IIJ.
2015-07-20 18:58:30 +00:00
yasuoka
fcbb4b5d79 Add missing initializations in privsep.c
From Yuuichi Someya at IIJ.
2015-07-20 18:55:35 +00:00
yasuoka
d4a4e79b7a Fixed a use-after-free. When handing the L2TP Proxy-LCP, a timer was used
to open LCP.  If the PPP session is terminated before the timer fires, the
timer had been fired with the freed context.  Stop using the timer to open
LCP.
2015-06-25 02:32:48 +00:00
yasuoka
6c0d88bb52 Reset the LCP option state for dialin-proxy only if re-negotiation is
enabled.
2015-06-25 02:25:33 +00:00
jmc
2182c25a3c tweak previous; 2015-06-24 10:09:32 +00:00
yasuoka
4781c8ec05 Fix npppd to terminate all PPP sessions properly even in case the
sending window for L2TP control is full when the control is terminating
(by a L2TP keepalive failure or other reasons).  In that case, if the
L2TP peer didn't respond at all, npppd had kept some PPP sessions
forever.
2015-06-24 05:20:16 +00:00
yasuoka
f65d56a491 Use the return value of event_loop() properly. Also abort(3) if
event_loop() returns abnormally which is unexpected.

diff from Yuuichi Someya
2015-06-24 04:57:55 +00:00
yasuoka
0607d03f79 Improve and fix typo in the comment. 2015-06-24 04:45:20 +00:00
yasuoka
5c938ccb58 Mention that pipex should be also configured by sysctl. 2015-06-24 04:34:31 +00:00
yasuoka
38377f60ae Fix npppd to check the size of received GRE packets properly. 2015-06-23 07:07:33 +00:00
yasuoka
3a6fc3410e Fix the problem when npppd receives a zero length 1701/udp packet. If
it receives such packets when the errno is not EAGAIN or EINTR, it had
closed all L2TP sessions and stoppped the L2TP server.  Also fix the
receiving GRE packet since it potentially has the same problem.
2015-06-23 06:59:54 +00:00
miod
8fc45048f3 Typos: equalivant, fucntion, libary. 2015-06-10 20:50:05 +00:00
yasuoka
e402d49ce7 Fix an uninitialized variable access when pptp.hostname is configured. 2015-05-12 05:30:24 +00:00
jsg
b6330afd10 Move the logit() prototype so parse.y will see it.
ok yasuoka@
2015-05-12 03:23:15 +00:00
guenther
fd7ad13f9e gcc 2.x is dead
ok millert@
2015-04-04 18:05:04 +00:00
miod
aaf20c4253 Fix garbage in error message; ok yasuoka@ 2015-02-17 05:12:51 +00:00
krw
a3fdc2c87f Replace some obvious '$OpenBSD' and '$OpenBSD:' typos with '$OpenBSD$'.
Pointed out by dickman@.

ok sthen@ phessler@
2015-01-22 14:33:01 +00:00
deraadt
dbad4650ad move to <limits.h> universe
ok yasuoka
2015-01-19 01:48:57 +00:00
yasuoka
4080edd532 Count number of sessions correctly. 2015-01-08 07:34:05 +00:00
tobias
9f0a0f7ab7 Fix typos in comments.
ok jmc, yasuoka
2014-11-27 10:22:38 +00:00
krw
83f4f91447 Yet more #include de-duplication.
ok deraadt@ tedu@
2014-11-20 14:51:41 +00:00
jsg
41eef22fad Don't allow embedded nul characters in strings.
Fixes a pfctl crash with an anchor name containing
an embedded nul found with the afl fuzzer.

pfctl parse.y patch from and ok deraadt@
2014-11-20 05:51:20 +00:00
tedu
9ee3e565b3 remove nt and lanman functions which aren't used. ok reyk yasuoka 2014-11-20 03:48:12 +00:00
krw
5376bb5a55 Nuke more obvious #include duplications.
ok deraadt@ millert@ tedu@
2014-11-18 20:54:28 +00:00
bluhm
e78bcbdd2b Convert the logic in yyerror(). Instead of creating a temporary
format string, create a temporary message.
OK doug@
2014-11-16 19:07:50 +00:00
doug
0f79392cb2 Add gcc printf format attributes to yyerror() in parse.y files.
No yyerror() calls needed to be changed.

ok bluhm@
2014-11-14 03:20:36 +00:00
yasuoka
00287df872 Fix a condition which selects log level for errors on routing socket,
since it was logically reverse.
2014-11-13 04:18:27 +00:00
yasuoka
3089d6fc88 When the pool address is changed and there is a PPP session which uses
the pool to be deleted, then the PPP session is to be deleted. But the
internal radish tree had kept the deleted session.  This causes
"use-after-free", and it had made npppd crash.
2014-11-13 04:03:53 +00:00
lteo
1543e3f792 Remove unnecessary netinet/in_systm.h include.
ok millert@
2014-10-25 03:23:49 +00:00
deraadt
15c8733c8b Use reallocarray()
ok doug
2014-10-18 04:12:57 +00:00
doug
a67e5f5728 close fd when fdopen fails
ok yasuoka@
2014-08-23 15:29:55 +00:00
jsg
bea5193ddb remove an uneeded test
ok yasuoka@
2014-08-22 04:36:16 +00:00
mpi
f252bd753c Do not set RTF_MASK, it is not used anymore.
ok yasuoka@
2014-08-14 08:08:00 +00:00
guenther
d077d9fd64 Correct the initializer for tunnconf_default_pptp
ok yasuoka@
2014-07-22 02:58:32 +00:00
yasuoka
5d71a92083 Handle msgbuf_write() returning EAGAIN.
from krw
2014-07-22 02:02:59 +00:00
guenther
be9b70502a Switch from <sys/endian.h> or <machine/endian.h> to the new,
being-standardized <endian.h>

ok deraadt@ millert@ beck@
2014-07-21 01:51:10 +00:00
yasuoka
b04f0284e7 Fix privsep.c. Call missing imsg_free() after imsg_get(). Also add
missing #include <net/if.h> to use IFNAMESIZ and replace some strncmp()
by startswith().
2014-07-18 13:16:22 +00:00
yasuoka
5789a5c98d Some functions need to dup() before sending a socket by imsg and don't
need to close() after sending socket since imsg_compose() closes the
passing socket.
2014-07-13 21:34:35 +00:00
yasuoka
0430ec61dc Fix a potential bug. privsep.c didn't check the interface name
correctly if it's pppx.
2014-07-12 20:07:07 +00:00
yasuoka
74d2d36c87 Fix error in previous. 2014-07-12 19:34:31 +00:00
yasuoka
114e92531d Fix the sentence in the BUGS section. Colon is usable for password.
Also add a mention about the escape sequence for the password.

pointed out giovanni
2014-07-12 14:55:22 +00:00
yasuoka
2a0f4e8a55 Use imsg(3) for the IPC between the privileged process and the
non-privileged process to be unify the way.  Also fix style.
2014-07-12 14:04:18 +00:00
yasuoka
d49e4bc49e Tweak accept pacing in pptp. Add handling when accept_add() fails and
add logging when accept() fails in EMFILE or ENFILE.
2014-07-10 13:48:03 +00:00
yasuoka
4241a1b696 Fix a double free bug in parsing the config. It had occurred when a
syntax error exists in radius {authentication,accounting}-server
configuration.  No need to free curr_radconf because it is a part of
auth_conf.

Pointed out Vladimir Seleznev
2014-07-08 19:00:12 +00:00
yasuoka
230b2897db Fix npppd not to access freed memory when it is exiting. 2014-07-08 18:49:27 +00:00
yasuoka
e8c0e2e5f1 Fix tcp-mss-adjust of pipex and npppd to update the pointer of
tcp option and check the boundary correctly.
2014-06-13 06:35:58 +00:00
yasuoka
1f03f1b318 Use calloc instead of malloc and memset.
from Benjamin Baier
2014-05-30 05:06:00 +00:00
yasuoka
eab1a1a95b Fixed chap_input() and chap_authenticate() not to be used as if they
return a value.  Since they are void function.

pointed out daniel, ok daniel
2014-05-28 16:14:19 +00:00
yasuoka
c3f3f34f44 Initialize struct iface by zero. Without this, npppd had used random
configuration.

from Anders Berggren.
2014-05-07 08:07:53 +00:00
tedu
9e298f67c0 calloc is simpler. suggested by Peter Malone and halex 2014-05-07 01:20:53 +00:00
tedu
ee353af9ca use calloc. from Peter Malone 2014-05-07 01:14:21 +00:00
yasuoka
194b1cddcc Delete duplicated "mppe" entry in keywords[]. 2014-05-05 04:58:23 +00:00
claudio
7cd4e04d10 Do not set RTF_DONE flag on route message, only the kernel is allowed to
set that to indicate that it processed the message. Also de-#ifdef the
RTF_MASK part, OpenBSD is not that archaic.
OK yasuoka@ long time ago
2014-04-18 10:05:22 +00:00
jsg
8716c48a97 sync with iked chap_ms.c 2014-04-16 05:57:05 +00:00
yasuoka
99d3c8607c Now tunnel can have multiple listen addresses. 2014-03-22 04:32:39 +00:00
yasuoka
34682664ae Reimplement control part of npppd(8) with imsg. Also add "monitor"
command for npppctl(8) to monitor PPP session start/stop events.
2014-03-22 04:30:31 +00:00
yasuoka
03f8ac39d3 Add an assert not to call radius_cancel_request() on callback. If the
assert is disabled by compile time, the function returns immediatly on that
condition.
2014-03-22 04:25:00 +00:00
yasuoka
34379bfe1a Fixed a bug in npppd_auth_get_user() which caused segmentation faults after
a user authentication is succeeded in case the authentication config option
has `username-suffix' and 'strip-atmark-realm' is yes. Delete
`username-prefix' from authentication setting.  This config option was
mis-leading and useless.
2014-03-22 04:23:17 +00:00
yasuoka
b0b96f978c In RADIUS accounting, realm_framed_ip_address was mistakenly used for
Framed-IP-Address.  acct_framed_ip_address should be used for that purpose.
2014-03-22 04:21:04 +00:00
yasuoka
20b2b42c29 Don't stop listening 1723/tcp when accept() is failed. 2014-03-22 04:19:54 +00:00
yasuoka
04a779e99b Stop output "Stopped" log message of the tunnel protocols. 2014-03-22 04:18:18 +00:00
guenther
acf82b0a9d lint is dead (long live the lint!), so stop using it as a cpp conditional
(namespace pollution!) or talking about its opinion on code.

ok krw@
2014-03-16 18:38:30 +00:00
benno
015d7b4d30 use u_char for buffers in yylex, for ctype calls
found by millert@, ok deraadt@
2013-11-25 12:51:10 +00:00
yasuoka
b5b5d8ebca Don't assume the length of chap challenges. 2013-09-20 07:29:19 +00:00
yasuoka
9d93772bc7 Add length check for Proxy LCP and Authentication AVPs. 2013-09-20 07:26:23 +00:00
yasuoka
dd8fd9c356 fix some gcc warnings 2013-09-13 03:25:27 +00:00
yasuoka
5acb4ed380 some npppd.conf(5) should be npppd(8). 2013-09-11 05:38:08 +00:00
naddy
8a774f81ed replace rand(3)/random(3) calls with secure arc4random*()
npppd ok yasuoka@
ok millert@
2013-08-26 14:15:07 +00:00
mlarkin
7262ab58da Extraneous local variable with useless increment applied.
found by Maxime Villard
2013-08-24 23:48:25 +00:00
yasuoka
bae23be9db Clarify what "mru" config option does.
input and ok giovanni jmc
2013-08-12 14:28:30 +00:00
yasuoka
ec8bab80a3 Stop doing pipex ioctl if no tunnel interface is configured. 2013-06-03 23:26:57 +00:00
gsoares
aa77089a88 fix typo in comment; OK yasuoka@ 2013-04-26 02:20:04 +00:00
yasuoka
c2307f159f Don't use random() because it's not safe. Use arc4random() instead of
it.  Suggested by deraadt.
2013-04-20 23:32:32 +00:00
yasuoka
06adecbe9d PPPoE server was broken since last configuration rework. Calling
pppoed_init() was accidentally deleted. Revert it in npppd_init() and
rearrange l2tpd_init() and pptpd_init() to the same place.

ok todd
2013-04-20 07:00:19 +00:00
yasuoka
82c6995acb Fix some AVPs of SCCRP to comply RFC 2661.
- Firmware revision and vendor name AVP are not mandatory.
- Hostname AVP must have 1 octect at least.
2013-04-16 07:45:19 +00:00
yasuoka
e43db91efc Fixed max-session' and user-max-session'. They has been broken by the
configuration reworking.
2013-04-16 07:42:27 +00:00
yasuoka
21cbc4229e Existing authentication realms are removed mistakenly when
the configuration is reloaded.
2013-04-16 07:31:20 +00:00
yasuoka
bc1389e9be Configuration option strip-nt-domain' and strip-atmark-realm' didn't
work since the parser mistakenly treated them as `eap-capable' option.

Pointed out by markus
2013-04-16 07:29:08 +00:00
yasuoka
3cdf74ee2a pppoed didn't work since it has been broken after the last
configuration parser change.

pointed out by todd.
2013-04-16 07:27:36 +00:00
giovanni
c38b0221bc Turn an error into a warning to be able to start l2tp tunnels even if
gre is not allowed.
ok yasuoka@
2013-04-06 17:03:51 +00:00
sthen
fbb5c869be typo: icpp/ipcp; from Renaud Allard 2013-03-19 12:49:30 +00:00
giovanni
20dd5096a6 Install npppd.conf with perms 0640, there could be the radius config on this file
ok yasuoka@
2013-03-14 16:20:46 +00:00
mpi
f49f8bc1ca Remove some faith-related #ifdef'd code that was only used for old IIJ
products and never enabled in our tree.

ok yasuoka@
2013-03-14 10:21:07 +00:00
deraadt
62e3c25282 handle ECONNABORTED errors from accept(). In many code blocks they can be
ignored silently and without aborting, much like EINTR and EWOULDBLOCK are.
ok's from various maintainers of these directories...
2013-03-11 17:40:09 +00:00
giovanni
72613efc38 do not start npppd if a pptp tunnel is configured but the gre protocol is not
enabled.
ok yasuoka@
2013-03-11 09:28:02 +00:00
yasuoka
de0a2dd6fb Pipex did panic when the 0 length mppe is given by ioctl. Return
EINVAL instead of panic.  Also npppd called ioctl with the invalid
argument because of the bugs introduced by the config parser change
commit.  Fixed those bugs and make sure not to use 0 length keys for
MPPE.

reported by csszep at gmail and giovanni
ok giovanni
2013-02-13 22:10:38 +00:00
yasuoka
90b6ff2cf4 Fix memory leak in privsep.c. Free the memories which were allocated by
getcap(3).
2013-02-08 12:35:52 +00:00
yasuoka
0099d8a4d1 add mention about 'mppe' configuration option which is missing.
pointed out by csszep at gmail.com
2013-02-08 12:15:33 +00:00
yasuoka
7f3c1c6c72 Because of the getcap(3) limitation, colon(':') can not be used for
password or username in npppd.conf.  Add this in the BUGS section.

pointed out by and ok giovanni
2013-02-08 12:04:15 +00:00
yasuoka
36859662cb Listening on IPv6 address is not supported for pptp tunnel. Document
this to the man page and refuse it by the config parser.
2013-02-08 11:06:26 +00:00
giovanni
1049b6f43f remove unused constant definition
ok yasuoka@
2013-02-06 11:47:18 +00:00
giovanni
e43f5e6d4b remove duplicated CPPFLAGS definition
ok yasuoka@
2013-02-06 11:45:48 +00:00
yasuoka
6b35b0758f port numbers for radius servers were not configured correctly.
pointed out by mxb and Robert Blacquiere
2013-01-31 09:44:21 +00:00
yasuoka
735f691f12 Deleting ip address of tun inteface was failed. This was caused by
passing wrong inteface name to ioctl().

pointed out by csszep at gmail.com
2013-01-31 02:14:46 +00:00
yasuoka
f91bf83594 Add pppx.4 and enable links to it.
ok dlg@
2013-01-29 15:42:20 +00:00
brad
565dd868d9 Remove inline from ppp_output() function to fix building with LLVM.
ok yasuoka@ millert@
2013-01-07 18:12:08 +00:00
sthen
ae857af592 Remove extra semicolon in "if (...);" which caused an incorrect flag to
be set in  _this->keylenbits. Found by scanning the tree using coccinelle.
ok yasuoka
2012-12-19 09:23:54 +00:00
deraadt
4a39ccd02c Remove excessive sys/cdefs.h inclusion
ok guenther millert kettenis
2012-12-05 23:19:48 +00:00
yasuoka
98f88edee8 Including ../../Makefile.inc was loop when npppd/obj is not a symbolic link.
Delete Makefile.inc and define BINDIR at npppd/Makefile directly.
2012-11-28 08:06:01 +00:00
yasuoka
59408346c5 Add accept.c from ldpd and use it to handle file descriptor exhaustion
in accept() case.

"go for it" deraadt
2012-11-13 17:10:40 +00:00
yasuoka
59b960865e Constify arguments to sendto_nat_t and add missing
#include "recvfromto.h" to l2tp_ctrl.c.  no binary changes.
2012-11-13 06:34:13 +00:00
yasuoka
32012184f0 framed-ip-address and framed-ip-netmask were not working.
pointed out by Andrew Ngo.
2012-09-28 23:46:00 +00:00
espie
dc31617316 gcc2 doesn't like unnamed fields. make this compile on vax again.
"looks right" deraadt@
2012-09-22 20:22:48 +00:00
jmc
0fd8ffeaf1 various fixes; ok yasuoka 2012-09-22 14:32:35 +00:00
jmc
a2ec5c8a63 various tweaks; 2012-09-21 09:03:32 +00:00
jmc
0472b88d97 various fixes; ok yasuoka 2012-09-20 20:28:09 +00:00
yasuoka
d483baad4f Enable npppd and npppctl in default build. Add npppd to rc and
install sample configs to /etc/.

ok claudio deraadt henning mcbride
2012-09-20 12:51:43 +00:00
yasuoka
05afa5beef tweak man pages.
- new sentence, new line
- on npppd.8 BUGS section, clarified that what is dropped is L2TP/IPsec
  packets
these must be included the previous commit.
2012-09-19 19:29:21 +00:00
yasuoka
f892cf2317 tweak man pages.
- add missing copyright
- delete comment lines from the template
- new sentence, new line
- on npppd.8 BUGS section, clarified that what is dropped is L2TP/IPsec
  packets
2012-09-19 18:33:56 +00:00
yasuoka
bdfe8fd00b cleanup around the pipex. naming style, delete or update comments.
no functional changes.
2012-09-19 17:50:17 +00:00
yasuoka
b4e25641b9 remove files that became unused by new configuration syntax. 2012-09-19 08:58:57 +00:00
yasuoka
5774b263ff fix mandoc -Tlint warnings. 2012-09-18 13:23:39 +00:00
yasuoka
821f7c5673 New configuration syntax for npppd(8). `npppd.conf' will be based on
parse.y and `npppd-users' will be based on getcap(3).  Add man pages.

feedback from giovanni
2012-09-18 13:14:08 +00:00
yasuoka
f6b8cd1c9a fix typo and comment
from umezawa at iij
2012-09-07 10:47:42 +00:00
yasuoka
a5018c90fb use IPsec flowinfo on pipex(4) to select the IPsec tunnel for sending
L2TP packets.

ok markus henning
2012-07-17 03:18:57 +00:00
markus
b56612b66b add IP_IPSECFLOWINFO option to sendmsg() and recvmsg(), so npppd(4)
can use this to select the IPsec tunnel for sending L2TP packets.
this fixes Windows (always binding to 1701) and Android clients
(negotiating wildcard flows); feedback mpf@ and yasuoka@;
ok henning@ and yasuoka@; ok jmc@ for the manpage
2012-07-16 18:05:35 +00:00
yasuoka
510ecc0260 npppd used wrong AVPs as a calling number' because break' in switch
case was missing.

ok claudio henning
2012-07-13 15:11:14 +00:00
giovanni
6c0f7cb557 Increase maximum number of tun interfaces to 8.
ok yasuoka@
2012-07-08 13:21:02 +00:00
yasuoka
ae71319efd don't use reigai' that means exception' in Japanese as labels.
no binary change.

from Michael W. Bombardieri
2012-06-05 06:31:27 +00:00
yasuoka
c1d3bc1c93 Delete rtev* that was to work around routing socket overflows.
This was forgotten on the prior commit.
2012-05-08 13:40:42 +00:00
yasuoka
84c9ec023f Fix a null reference bug on terminating the process.
seems ok henning, ok mcbride
2012-05-08 13:30:16 +00:00
yasuoka
b01648a9c0 Result-Code AVP of StopCCN was not parsed properly.
seems ok henning, ok mcbride
2012-05-08 13:28:06 +00:00
yasuoka
d2083829b4 Ignore NAK of authentication protocol option on LCP that was not
requested.

ok mcbride henning
2012-05-08 13:26:12 +00:00
yasuoka
2160905138 Fix double free bug in PAP with radius authentication.
(found by yus at iij)

ok mcbride henning
2012-05-08 13:23:53 +00:00
yasuoka
45ec9325ae Ignore ACCM option on LCP. This was required by some LAC that uses
the option in proxied LCP.

ok mcbride henning
2012-05-08 13:20:44 +00:00
yasuoka
9a200ddf43 Trivial changes from the upstream(IIJ).
- fix styles, compile errors in some ifdef condition and compiler warnings.
 - delete rtev* that was to work around routing socket overflows.
 - delete is_ctrl argument from l2tp_ctrl_send_packet().  It's not used.
 - tweak returning the exit status.
 - use IPV6_IPSEC_POLICY for IPv6 socket.
   (though npppd cannot set up a ipsec policy to the socket yet.)

ok mcbride henning
2012-05-08 13:18:37 +00:00
yasuoka
7a7bab9d0f Fix comments and styles. Delete unused variables and labels.
No binary changes.

ok mcbride henning
2012-05-08 13:15:11 +00:00