mischief/openbsd-src
1
0
Fork 0
mirror of https://github.com/openbsd/src.git synced 2025-01-03 06:45:37 -08:00
Code

Don't check op_q_alloc for non-NULL before invoking op_q_free.

Browse Source 
Check op_q_free for non-NULL instead.

Neither are currently set to non-NULL anywhere.

ok jmatthew@
This commit is contained in:
krw 2024-07-08 16:07:36 +00:00
parent 2e5628f880
commit e163d0c441
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/dev/ic/nvme.c
View File

@ -1,4 +1,4 @@
/* $OpenBSD: nvme.c,v 1.118 2024/06/30 12:03:17 krw Exp $ */ /* $OpenBSD: nvme.c,v 1.119 2024/07/08 16:07:36 krw Exp $ */
/* /*
* Copyright (c) 2014 David Gwynne <dlg@openbsd.org> * Copyright (c) 2014 David Gwynne <dlg@openbsd.org>
@ -1538,7 +1538,7 @@ nvme_q_free(struct nvme_softc *sc, struct nvme_queue *q)
nvme_dmamem_sync(sc, q->q_cq_dmamem, BUS_DMASYNC_POSTREAD); nvme_dmamem_sync(sc, q->q_cq_dmamem, BUS_DMASYNC_POSTREAD);
nvme_dmamem_sync(sc, q->q_sq_dmamem, BUS_DMASYNC_POSTWRITE); nvme_dmamem_sync(sc, q->q_sq_dmamem, BUS_DMASYNC_POSTWRITE);
if (sc->sc_ops->op_q_alloc != NULL) if (sc->sc_ops->op_q_free != NULL)
sc->sc_ops->op_q_free(sc, q); sc->sc_ops->op_q_free(sc, q);
nvme_dmamem_free(sc, q->q_cq_dmamem); nvme_dmamem_free(sc, q->q_cq_dmamem);