mischief/openbsd-src
1
0
Fork 0
mirror of https://github.com/openbsd/src.git synced 2024-12-21 23:18:00 -08:00
Code

pwd_mkdb: limit db entries to _PW_BUF_LEN to match libc

Browse Source 
Otherwise, it is possible to create a passwd(5) entry that is too
large for getpwent(3), which ignores database entries larger than
_PW_BUF_LEN.  This adds a check in db_store() so that we do not
store an entry larger than getpwent(3) can read.  Callers of
pwd_mkdb(8), typically via pw_mkdb(3), already check for failure.

In most cases, the checks in chpass(1) will prevent a user from
creating an entry that is too large by changing their gecos field.
However, it is only when storing the db record that we know the
true size.

OK deraadt@
This commit is contained in:
millert 2024-07-28 19:13:26 +00:00
parent 324a3c8c4f
commit a63a57f896
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
usr.sbin/pwd_mkdb/pwd_mkdb.c
View File

@ -1,4 +1,4 @@
/* $OpenBSD: pwd_mkdb.c,v 1.61 2023/04/19 12:58:16 jsg Exp $ */
/* $OpenBSD: pwd_mkdb.c,v 1.62 2024/07/28 19:13:26 millert Exp $ */
/*-
* Copyright (c) 1991, 1993, 1994
@ -608,6 +608,10 @@ db_store(FILE *fp, FILE *oldfp, DB *edp, DB *dp, struct passwd *pw,
p += sizeof(int);
data.size = p - buf;
/* getpwent() does not support entries > _PW_BUF_LEN. */
if (data.size > _PW_BUF_LEN)
fatalx("%s: entry too large", pw->pw_name);
/* Write the secure record. */
if ((edp->put)(edp, &key, &data, dbmode) == -1)
fatal("put");