mischief/openbsd-src
1
0
Fork 0
mirror of https://github.com/openbsd/src.git synced 2024-12-22 16:42:56 -08:00
Code

Add regress coverage for tls_peer_cert_common_name()

Browse Source
This commit is contained in:
tb 2024-12-10 08:43:17 +00:00
parent 5ad0d35887
commit 7f9db3f573
2 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
regress/lib/libtls/gotls/tls.go
View File

@ -202,6 +202,15 @@ func (t *TLS) PeerCertIssuer() (string, error) {
return C.GoString(issuer), nil return C.GoString(issuer), nil
} }
// PeerCertCommonName returns the common name of the peer certificate.
func (t *TLS) PeerCertCommonName() (string, error) {
commonName := C.tls_peer_cert_common_name(t.ctx)
if commonName == nil {
return "", errors.New("no peer cert common name returned")
}
return C.GoString(commonName), nil
}
// PeerCertSubject returns the subject of the peer certificate. // PeerCertSubject returns the subject of the peer certificate.
func (t *TLS) PeerCertSubject() (string, error) { func (t *TLS) PeerCertSubject() (string, error) {
subject := C.tls_peer_cert_subject(t.ctx) subject := C.tls_peer_cert_subject(t.ctx)

8
regress/lib/libtls/gotls/tls_test.go
View File

@ -418,6 +418,9 @@ func TestTLSInfo(t *testing.T) {
if _, err := tls.PeerCertSubject(); err == nil { if _, err := tls.PeerCertSubject(); err == nil {
t.Error("PeerCertSubject() returned nil error, want error") t.Error("PeerCertSubject() returned nil error, want error")
} }
if _, err := tls.PeerCertCommonName(); err == nil {
t.Error("PeerCertCommonName() returned nil error, want error")
}
if _, err := tls.PeerCertHash(); err == nil { if _, err := tls.PeerCertHash(); err == nil {
t.Error("PeerCertHash() returned nil error, want error") t.Error("PeerCertHash() returned nil error, want error")
} }
@ -468,6 +471,11 @@ func TestTLSInfo(t *testing.T) {
} else { } else {
t.Logf("Subject: %v", subject) t.Logf("Subject: %v", subject)
} }
if commonName, err := tls.PeerCertCommonName(); err != nil {
t.Errorf("PeerCertCommonName() returned error: %v", err)
} else {
t.Logf("Subject: %v", commonName)
}
if hash, err := tls.PeerCertHash(); err != nil { if hash, err := tls.PeerCertHash(); err != nil {
t.Errorf("PeerCertHash() returned error: %v", err) t.Errorf("PeerCertHash() returned error: %v", err)
} else if hash != certHash { } else if hash != certHash {