mischief/openbsd-src
1
0
Fork 0
mirror of https://github.com/openbsd/src.git synced 2024-12-21 23:18:00 -08:00
Code

In do_zzz a garbage stack value could be accessed in case a read

Browse Source 
or write in send_command failed.
Found by codechecker.
OK deraadt
This commit is contained in:
mbuhl 2022-11-09 18:48:11 +00:00
parent fabf5c2497
commit 3abecac13e
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
usr.sbin/apm/apm.c
View File

@ -1,4 +1,4 @@
/* $OpenBSD: apm.c,v 1.42 2022/09/10 10:10:09 sdk Exp $ */
/* $OpenBSD: apm.c,v 1.43 2022/11/09 18:48:11 mbuhl Exp $ */
/*
* Copyright (c) 1996 John T. Kohl
@ -99,6 +99,8 @@ do_zzz(int fd, enum apm_action action)
char *msg;
int ret;
bzero(&reply, sizeof reply);
switch (action) {
case NONE:
case SUSPEND:
@ -119,7 +121,7 @@ do_zzz(int fd, enum apm_action action)
printf("%s...\n", msg);
ret = send_command(fd, &command, &reply);
if (reply.error)
if (ret == 0 && reply.error)
errx(1, "%s: %s", apm_state(reply.newstate), strerror(reply.error));
exit(ret);
}