mischief/openbsd-src
1
0
Fork 0
mirror of https://github.com/openbsd/src.git synced 2025-01-03 06:45:37 -08:00
Code

When decoding SVCB or HTTPS do not skip reading params in alias

Browse Source 
mode.  According to the RFC, client shoud ignore them (which means
actively skipping), but for dig it make sense to print them anyway.
ok florian@
This commit is contained in:
otto 2024-10-31 07:40:34 +00:00
parent dd517d5d67
commit 16df6568a5
1 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
usr.bin/dig/lib/dns/rdata/in_1/svcb_64.c
View File

@ -15,7 +15,7 @@
* PERFORMANCE OF THIS SOFTWARE.
*/
/* $Id: svcb_64.c,v 1.1 2022/07/03 12:07:52 florian Exp $ */
/* $Id: svcb_64.c,v 1.2 2024/10/31 07:40:34 otto Exp $ */
/* draft-ietf-dnsop-svcb-https-10, based on srv_33.c */
@ -197,7 +197,6 @@ fromwire_in_svcb_https(ARGS_FROMWIRE) {
dns_name_t name;
isc_region_t sr;
unsigned int svc_param_value_len;
int alias_mode = 0;
UNUSED(type);
UNUSED(rdclass);
@ -213,20 +212,12 @@ fromwire_in_svcb_https(ARGS_FROMWIRE) {
if (sr.length < 2)
return (ISC_R_UNEXPECTEDEND);
RETERR(isc_mem_tobuffer(target, sr.base, 2));
alias_mode = uint16_fromregion(&sr) == 0;
isc_buffer_forward(source, 2);
/*
* TargetName.
*/
RETERR(dns_name_fromwire(&name, source, dctx, options, target));
if (alias_mode) {
/*
* In AliasMode, recipients MUST ignore any SvcParams that
* are present.
*/
return (ISC_R_SUCCESS);
}
isc_buffer_activeregion(source, &sr);
while (sr.length > 0) {